fix: nightly CI failures + workaround RUSTFLAGS cargo-make leak#49
Open
wmmc88 wants to merge 2 commits intomicrosoft:mainfrom
Open
fix: nightly CI failures + workaround RUSTFLAGS cargo-make leak#49wmmc88 wants to merge 2 commits intomicrosoft:mainfrom
wmmc88 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
- Remove unnecessary trailing commas in format!/println! macros to pass new nightly clippy::unnecessary_trailing_comma lint - Reorder underscore-prefixed imports to match nightly rustfmt sorting
wmmc88
force-pushed
the
fix/unnecessary-trailing-commas
branch
from
1f202f0 to
de907c7
Compare
wmmc88
changed the title
Unset RUSTFLAGS for the cargo-make step in build.yaml to prevent -D warnings from leaking into rust-script compilation of wdk-build. Only cargo-make is affected since it uses rust-script to compile inline build scripts where wdk-build is a path dependency (via symlink), bypassing cargo's --cap-lints. cargo-wdk and cargo install are normal cargo operations with proper --cap-lints handling and do not need this workaround. Temporary workaround until microsoft/windows-drivers-rs#629 is merged and a new wdk-build is published. Tracked in ADO Bug #5396440.
wmmc88
force-pushed
the
fix/unnecessary-trailing-commas
branch
from
1683801 to
bcbb043
Compare
Alan632
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
1. Fix nightly clippy + rustfmt failures
Edits to pass new nightly
clippy::unnecessary_trailing_commalint and nightly rustfmt import reordering.format!/println!macros (general/echo/kmdf/exe/src/main.rs)device.rs,queue.rs,driver.rs)Failed CI run: https://github.com/microsoft/Windows-rust-driver-samples/actions/runs/22519532366
2. Workaround RUSTFLAGS leaking into cargo-make/cargo-wdk builds
Unset
RUSTFLAGSforcargo make,cargo wdk install, andcargo wdk buildsteps inbuild.yaml. This prevents-D warningsfrom leaking intorust-scriptcompilation ofwdk-build(which is treated as a path dependency via symlink, bypassing cargo's--cap-lints allow).Temporary workaround until microsoft/windows-drivers-rs#629 is merged and a new
wdk-buildis published.